Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362743002: Report an error from dart2dart when deferred loading is used. (Closed)

Created:
6 years, 5 months ago by sigurdm
Modified:
6 years, 5 months ago
Reviewers:
asgerf, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report an error from dart2dart when deferred loading is used. R=asgerf@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=37867

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sigurdm
6 years, 5 months ago (2014-07-01 10:58:43 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/362743002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/362743002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode1178 sdk/lib/_internal/compiler/implementation/warnings.dart:1178: "Deferred loading is not supported by the dart ...
6 years, 5 months ago (2014-07-01 11:39:05 UTC) #2
asgerf
LGTM
6 years, 5 months ago (2014-07-01 12:16:45 UTC) #3
sigurdm
https://codereview.chromium.org/362743002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/362743002/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode1178 sdk/lib/_internal/compiler/implementation/warnings.dart:1178: "Deferred loading is not supported by the dart backend."); ...
6 years, 5 months ago (2014-07-01 12:27:54 UTC) #4
sigurdm
6 years, 5 months ago (2014-07-01 12:37:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r37867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698