Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 362553005: Check that script tag has at least src or inlined text, add unrelated test (Closed)

Created:
6 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check that script tag has at least src or inlined text. Also adds an unrelated tests for something we have already fixed. Committed: https://code.google.com/p/dart/source/detail?r=37836

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M pkg/polymer/lib/src/build/linter.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-06-30 20:08:38 UTC) #1
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-06-30 21:23:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r37836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698