Issue 362343003: dart2dart: Use implicit 'this' when generating Dart code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362343003: dart2dart: Use implicit 'this' when generating Dart code. (Closed)

Created:
6 years, 5 months ago by asgerf

Modified:
6 years, 5 months ago

Reviewers:
Kevin Millikin (Google), sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart: Use implicit 'this' when generating Dart code. Expressions like this.x will be printed simply as x. The renaming phase seems to disambiguate things so x is not captured. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37975

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed test case #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -6 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart	View		2 chunks	+8 lines, -4 lines	0 comments	Download
A	tests/language/rewrite_implicit_this_test.dart	View	1	1 chunk	+107 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sigurdm

lgtm https://codereview.chromium.org/362343003/diff/1/tests/language/rewrite_implicit_this_test.dart File tests/language/rewrite_implicit_this_test.dart (right): https://codereview.chromium.org/362343003/diff/1/tests/language/rewrite_implicit_this_test.dart#newcode10 tests/language/rewrite_implicit_this_test.dart:10: int x = 'x'; var x = 'x'; ...

6 years, 5 months ago (2014-07-03 07:48:12 UTC) #2

asgerf

6 years, 5 months ago (2014-07-03 08:06:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37975 (presubmit successful).

Expand Messages | Collapse Messages