Issue 362243003: Generate mock libraries and assert that helpers are non-null.

Issue 362243003: Generate mock libraries and assert that helpers are non-null. (Closed)

Created:
6 years, 5 months ago by Johnni Winther

Modified:
6 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate mock libraries and assert that helpers are non-null. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=37979

Patch Set 2 : Updated cf. comments. #

Patch Set 4 : Fix after rebase. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+448 lines, -523 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	10 chunks	+28 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View	1 2	4 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	4 chunks	+15 lines, -232 lines	0 comments	Download
A	tests/compiler/dart2js/mock_libraries.dart	View	1 2 3	1 chunk	+337 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/patch_test.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	1 2	2 chunks	+4 lines, -19 lines	0 comments	Download
M	tests/compiler/dart2js/size_test.dart	View	1	1 chunk	+16 lines, -18 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1	1 chunk	+34 lines, -46 lines	0 comments	Download
M	tests/compiler/dart2js/value_range_test.dart	View		1 chunk	+0 lines, -88 lines	0 comments	Download
M	tests/utils/dummy_compiler_test.dart	View		2 chunks	+9 lines, -88 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/362243003/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/362243003/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode671 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:671: enqueue(enqueuer, find(jsHelperLibrary, 'iae'), registry); Why did you change ...

6 years, 5 months ago (2014-07-03 08:31:16 UTC) #2

Johnni Winther

https://codereview.chromium.org/362243003/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/362243003/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode671 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:671: enqueue(enqueuer, find(jsHelperLibrary, 'iae'), registry); On 2014/07/03 08:31:15, karlklose wrote: ...

6 years, 5 months ago (2014-07-03 09:23:25 UTC) #3

Johnni Winther

6 years, 5 months ago (2014-07-03 09:33:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r37979 (presubmit successful).

Expand Messages | Collapse Messages