Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 360973002: Add a "--log" option to analysis server to dump log messages to a file. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a "--log" option to analysis server to dump log messages to a file. R=brianwilkerson@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=37902

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M pkg/analysis_server/lib/driver.dart View 3 chunks +21 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-01 16:27:31 UTC) #1
jwren
On 2014/07/01 16:27:31, Paul Berry wrote: LGTM
6 years, 5 months ago (2014-07-01 16:53:42 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/360973002/diff/1/pkg/analysis_server/lib/driver.dart File pkg/analysis_server/lib/driver.dart (right): https://codereview.chromium.org/360973002/diff/1/pkg/analysis_server/lib/driver.dart#newcode76 pkg/analysis_server/lib/driver.dart:76: sink.writeln(record); Where do we close the file?
6 years, 5 months ago (2014-07-01 17:30:01 UTC) #3
Paul Berry
https://codereview.chromium.org/360973002/diff/1/pkg/analysis_server/lib/driver.dart File pkg/analysis_server/lib/driver.dart (right): https://codereview.chromium.org/360973002/diff/1/pkg/analysis_server/lib/driver.dart#newcode76 pkg/analysis_server/lib/driver.dart:76: sink.writeln(record); On 2014/07/01 17:30:01, Brian Wilkerson wrote: > Where ...
6 years, 5 months ago (2014-07-01 17:51:12 UTC) #4
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-01 18:41:25 UTC) #5
Paul Berry
6 years, 5 months ago (2014-07-01 20:22:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r37902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698