Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 36073010: Remove deprecated 'str' getter on Match. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Found two more uses of .str. #

Patch Set 3 : Found two more uses of str #

Patch Set 4 : Updated expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M runtime/lib/regexp_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/regexp_helper.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/string_helper.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/core/regexp.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/co19/co19-co19.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/string_pattern_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-23 14:34:08 UTC) #1
floitsch
LGTM.
7 years, 2 months ago (2013-10-23 15:24:41 UTC) #2
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-24 12:06:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r29167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698