Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 360503003: Eliminate calls to Isolate::Current from the flow-graph builder. (Closed)

Created:
6 years, 5 months ago by Florian Schneider
Modified:
6 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate calls to Isolate::Current from the flow-graph builder. Instead, use the saved isolate of the graph builder. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -318 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 127 chunks +330 lines, -318 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 5 months ago (2014-06-27 13:22:57 UTC) #1
srdjan
lgtm
6 years, 5 months ago (2014-06-27 17:02:52 UTC) #2
Florian Schneider
6 years, 5 months ago (2014-06-30 09:04:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37811 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698