Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 360393003: New analyzer snapshot. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

New analyzer snapshot. Mostly to get GetContentTask.internalPerform() to catch all exceptions. We throw non-Java exception from memory resource, so we cannot test not existing parts/libraries cases in server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -42 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GetContentTask.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 11 chunks +251 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 3 chunks +2 lines, -21 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +70 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +83 lines, -16 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-01 20:52:52 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-01 20:57:00 UTC) #2
scheglov
6 years, 5 months ago (2014-07-01 21:01:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698