Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 360373003: Enable top exit frame profiler mode by default + Windows fixes (Closed)

Created:
6 years, 5 months ago by Cutch
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Enable top exit frame profiler mode by default - Final Windows fixes for using StackFrameIterator from different thread. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37918

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.h View 1 5 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/stack_frame.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
6 years, 5 months ago (2014-07-01 21:18:28 UTC) #1
siva
lgtm
6 years, 5 months ago (2014-07-01 22:08:25 UTC) #2
Cutch
6 years, 5 months ago (2014-07-01 22:21:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698