Add LibraryMirror.declarations and ClassMirror.declarations to the API and both implementations.

Add LibraryMirror.declarations and ClassMirror.declarations to the API and both implementations.

Fix bug where partially unmangled names were used in constructor names.

Fix bug where type variables were considered static.

R=gbracha@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29261

[rmacnak, 2013-10-22 21:40:03]

Starting a new CL because Rietveld seem to have trouble matching the base files
for the old, quite-out-of-sync one.

Updated tests to not expect typedefs to be classes.

Updated tests not to expect type variables from anonymous mixin applications.

Updated tests to use Expect.setEquals so diffs are tolerably readable.

Fixed bug in building constructor names.

[gbracha, 2013-10-22 22:26:50]

tests lgtm with comments

https://codereview.chromium.org/36023003/diff/70001/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/36023003/diff/70001/sdk/lib/mirrors/mirrors.d...
sdk/lib/mirrors/mirrors.dart:802: Map<Symbol, DeclarationMirror> get
declarations;
So, we are providing typeVariables as an accessor in TypeMirror to deal with
both generic classes and generic typedefs. Should we still provide type
variables as part of declarations? Arguably yes, because that gives us a
complete picture of all the names declared in the scope of the class, but ar ewe
sure?

https://codereview.chromium.org/36023003/diff/70001/tests/lib/mirrors/class_d...
File tests/lib/mirrors/class_declarations_test.dart (right):

https://codereview.chromium.org/36023003/diff/70001/tests/lib/mirrors/class_d...
tests/lib/mirrors/class_declarations_test.dart:75: ['TypeVariable(s(C) in
s(Class), upperBound = Class(s(Object) in s(dart.core), top-level))',
So why is a type variable static? It isn't even legal in a static context.

[rmacnak, 2013-10-22 22:44:56]

https://codereview.chromium.org/36023003/diff/70001/tests/lib/mirrors/class_d...
File tests/lib/mirrors/class_declarations_test.dart (right):

https://codereview.chromium.org/36023003/diff/70001/tests/lib/mirrors/class_d...
tests/lib/mirrors/class_declarations_test.dart:75: ['TypeVariable(s(C) in
s(Class), upperBound = Class(s(Object) in s(dart.core), top-level))',
On 2013/10/22 22:26:50, gbracha wrote:
> So why is a type variable static? It isn't even legal in a static context.

Fixed.

[Johnni Winther, 2013-10-25 06:10:02]

lgtm

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
File tests/lib/mirrors/class_declarations_test.dart (right):

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:38:
cm.declarations.values.where((dm) => dm is MethodMirror &&
dm.isGetter).map(stringify),
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:46:
cm.declarations.values.where((dm) => dm is MethodMirror &&
dm.isSetter).map(stringify),
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:59:
cm.declarations.values.where((dm) => dm is MethodMirror &&
dm.isRegularMethod).map(stringify),
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:65:
'Method(s(Class._redirectingConstructor) in s(Class), private, constructor)',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:66:
'Method(s(Class._redirectingFactory) in s(Class), private, static,
constructor)',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:71:
cm.declarations.values.where((dm) => dm is MethodMirror &&
dm.isConstructor).map(stringify),
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:76:
'Method(s(Class._redirectingFactory) in s(Class), private, static,
constructor)',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:92: 'TypeVariable(s(C) in
s(Class), upperBound = Class(s(Object) in s(dart.core), top-level))',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:94:
'Method(s(Class._redirectingConstructor) in s(Class), private, constructor)',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:111: 'TypeVariable(s(C) in
s(Class), upperBound = Class(s(Object) in s(dart.core), top-level))',
Long line.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/class_declarations_test.dart:133: 'TypeVariable(s(C) in
s(Class), upperBound = Class(s(Object) in s(dart.core), top-level))',
Long line ... and several below.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
File tests/lib/mirrors/declarations_model.dart (right):

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/declarations_model.dart:91:
Superclass.inheritedRedirectingConstructor(x) :
this.inheritedGenerativeConstructor(x*2);
Long line ... and several below.

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
File tests/lib/mirrors/library_declarations_test.dart (right):

https://chromiumcodereview.appspot.com/36023003/diff/120001/tests/lib/mirrors...
tests/lib/mirrors/library_declarations_test.dart:14: LibraryMirror lm =
currentMirrorSystem().findLibrary(#test.declarations_model).single;
Long line ... and several below.

[rmacnak, 2013-10-25 17:00:00]

Shortened lines.

[rmacnak, 2013-10-25 17:05:59]

Committed patchset #5 manually as r29261 (presubmit successful).