Observatory: Lexicaly sort all kinds of lists (imports, libraries, classes, functions, fields).

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37922

[Cutch, 2014-06-30 23:26:44]

https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1010:
imports.addAll(unifyByName(map['imports']));
Why are there duplicate names?

[Michael Lippautz (Google), 2014-06-30 23:42:10]

https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1010:
imports.addAll(unifyByName(map['imports']));
On 2014/06/30 23:26:44, Cutch wrote:
> Why are there duplicate names?

The vm may return duplicates for libraries that also have a part that is patched
in, because both, the actual script and the -patch part, can have imports (which
may be the same).

[Cutch, 2014-07-01 14:35:56]

On 2014/06/30 23:42:10, Michael Lippautz wrote:
>
https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
> File runtime/bin/vmservice/client/lib/src/service/object.dart (right):
> 
>
https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
> runtime/bin/vmservice/client/lib/src/service/object.dart:1010:
> imports.addAll(unifyByName(map['imports']));
> On 2014/06/30 23:26:44, Cutch wrote:
> > Why are there duplicate names?
> 
> The vm may return duplicates for libraries that also have a part that is
patched
> in, because both, the actual script and the -patch part, can have imports
(which
> may be the same).

I'm not sure we should unify these by name. If they are two distinct library we
should include both in the list. Could we improve the names of these libraries
so they are more distinct?

[Michael Lippautz (Google), 2014-07-01 16:28:16]

On 2014/07/01 14:35:56, Cutch wrote:
> On 2014/06/30 23:42:10, Michael Lippautz wrote:
> >
>
https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
> > File runtime/bin/vmservice/client/lib/src/service/object.dart (right):
> > 
> >
>
https://codereview.chromium.org/359833002/diff/20001/runtime/bin/vmservice/cl...
> > runtime/bin/vmservice/client/lib/src/service/object.dart:1010:
> > imports.addAll(unifyByName(map['imports']));
> > On 2014/06/30 23:26:44, Cutch wrote:
> > > Why are there duplicate names?
> > 
> > The vm may return duplicates for libraries that also have a part that is
> patched
> > in, because both, the actual script and the -patch part, can have imports
> (which
> > may be the same).
> 
> I'm not sure we should unify these by name. If they are two distinct library
we
> should include both in the list. Could we improve the names of these libraries
> so they are more distinct?

PTAL: as discussed, removed dups by .id

[Cutch, 2014-07-01 17:33:14]

lgtm

[Michael Lippautz (Google), 2014-07-01 23:06:22]

Committed patchset #5 manually as r37922 (presubmit successful).