Issue 359673002: - Remove Dart_ReceivePortGetId, Dart_GetReceivePort and Dart_PostMessage.

Issue 359673002: - Remove Dart_ReceivePortGetId, Dart_GetReceivePort and Dart_PostMessage. (Closed)

Created:
6 years, 6 months ago by siva

Modified:
6 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Remove Dart_ReceivePortGetId, Dart_GetReceivePort and Dart_PostMessage. - Change _EventHandler._sendData to use a sendport object instead of a receiveport object. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37827

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -92 lines)			Patch
M	runtime/bin/eventhandler.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_patch.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/include/dart_api.h	View	1	1 chunk	+7 lines, -21 lines	0 comments	Download
M	runtime/vm/custom_isolate_test.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+6 lines, -55 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/eventhandler.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/timer_impl.dart	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM once the documentation is updated. Thanks, -Ivan https://chromiumcodereview.appspot.com/359673002/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/359673002/diff/1/runtime/include/dart_api.h#newcode1182 runtime/include/dart_api.h:1182: * ...

6 years, 6 months ago (2014-06-27 06:21:49 UTC) #2

siva

https://chromiumcodereview.appspot.com/359673002/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/359673002/diff/1/runtime/include/dart_api.h#newcode1182 runtime/include/dart_api.h:1182: * Returns Dart_Null if the provided port is not ...

6 years, 5 months ago (2014-06-30 17:18:14 UTC) #3

siva

6 years, 5 months ago (2014-06-30 17:46:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37827 (presubmit successful).

Expand Messages | Collapse Messages