Issue 359413006: Fix handling of type literals.

Issue 359413006: Fix handling of type literals. (Closed)

Created:
6 years, 5 months ago by Johnni Winther

Modified:
6 years, 5 months ago

Reviewers:
asgerf, sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix handling of type literals. Continued work on https://codereview.chromium.org/355373002/ BUG= R=asgerf@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37859

Patch Set 2 : Split visitTypeReferenceSend #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -44 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/const_expression.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart	View	1 2	2 chunks	+14 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolved_visitor.dart	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	3 chunks	+10 lines, -7 lines	0 comments	Download
A +	tests/language/dynamic_type_literal_test.dart	View	1 2	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

asgerf

I'm not familiar with type_inferrer and SSA builder, but the rest LGTM. https://codereview.chromium.org/359413006/diff/20001/tests/language/dynamic_type_literal_test.dart File tests/language/dynamic_type_literal_test.dart ...

6 years, 5 months ago (2014-07-01 09:30:29 UTC) #2

sigurdm

lgtm https://codereview.chromium.org/359413006/diff/20001/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/359413006/diff/20001/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1314 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1314: // TODO(asgerf): Change this to match proposed semantics ...

6 years, 5 months ago (2014-07-01 09:39:56 UTC) #3

Johnni Winther

https://codereview.chromium.org/359413006/diff/20001/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/359413006/diff/20001/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1314 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1314: // TODO(asgerf): Change this to match proposed semantics of ...

6 years, 5 months ago (2014-07-01 10:53:01 UTC) #4

Johnni Winther

6 years, 5 months ago (2014-07-01 11:02:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r37859 (presubmit successful).

Expand Messages | Collapse Messages