Issue 35923002: Cap the number of FDs used by barback at 32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 35923002: Cap the number of FDs used by barback at 32. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom, Alan Knight, dgrove

CC:
reviews_dartlang.org, Anders Johnsen, Søren Gjesse, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cap the number of FDs used by barback at 32. BUG=13752 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=29034

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -22 lines)			Patch
	M	pkg/barback/lib/src/file_pool.dart	View		1 chunk	+3 lines, -2 lines	1 comment	Download
	M	pkg/barback/lib/src/utils.dart	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r29034 (presubmit successful).

7 years, 2 months ago (2013-10-22 20:30:13 UTC) #3

dgrove

https://codereview.chromium.org/35923002/diff/1/pkg/barback/lib/src/file_pool.dart File pkg/barback/lib/src/file_pool.dart (right): https://codereview.chromium.org/35923002/diff/1/pkg/barback/lib/src/file_pool.dart#newcode43 pkg/barback/lib/src/file_pool.dart:43: final int _maxOpenFiles = 32; Did you try measuring ...

7 years, 2 months ago (2013-10-22 20:31:47 UTC) #4

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages