Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 35893012: Use enums for the index of IL operands. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use enums for the index of IL operands. Addressing comments from a previous CL (https://codereview.chromium.org/28633003/). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -29 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language.h View 5 chunks +45 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-10-23 09:43:43 UTC) #1
srdjan
lgtm
7 years, 2 months ago (2013-10-23 14:27:25 UTC) #2
Florian Schneider
7 years, 2 months ago (2013-10-23 15:27:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29087 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698