Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 35893008: Preemptive initialization of dispatch records (Closed)

Created:
7 years, 2 months ago by sra1
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Preemptive initialization of dispatch records R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29111

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M sdk/lib/_internal/lib/interceptors.dart View 3 chunks +9 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/native_helper.dart View 1 2 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sra1
Pete, I'm a bit nervous about patching all the prototypes like this. Is there a ...
7 years, 2 months ago (2013-10-23 04:35:27 UTC) #1
blois
Not that I can think of- what cases are you worried about? https://codereview.chromium.org/35893008/diff/40001/sdk/lib/_internal/lib/native_helper.dart File sdk/lib/_internal/lib/native_helper.dart ...
7 years, 2 months ago (2013-10-23 16:37:03 UTC) #2
sra1
https://codereview.chromium.org/35893008/diff/40001/sdk/lib/_internal/lib/native_helper.dart File sdk/lib/_internal/lib/native_helper.dart (right): https://codereview.chromium.org/35893008/diff/40001/sdk/lib/_internal/lib/native_helper.dart#newcode327 sdk/lib/_internal/lib/native_helper.dart:327: if (JS('bool', 'typeof (#[#]) != "undefined"', context, tag)) { ...
7 years, 2 months ago (2013-10-23 18:30:34 UTC) #3
blois
lgtm
7 years, 2 months ago (2013-10-23 18:37:55 UTC) #4
sra1
7 years, 2 months ago (2013-10-23 19:11:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698