Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 358723002: Add Instance::HashCode that matches hashCode. (Closed)

Created:
6 years, 6 months ago by koda
Modified:
6 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add Instance::HashCode that matches hashCode. Implement in C++ for strings and integers. This is in preparation for internalized hash maps/sets. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=37763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M runtime/vm/dart_entry.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 6 months ago (2014-06-25 23:23:26 UTC) #1
rmacnak
LGTM
6 years, 6 months ago (2014-06-26 20:21:38 UTC) #2
koda
6 years, 6 months ago (2014-06-26 21:53:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698