Issue 35863006: Fix for getContextAttributes which wraps bare dictionary into a Dart type.

Issue 35863006: Fix for getContextAttributes which wraps bare dictionary into a Dart type. (Closed)

Created:
7 years, 2 months ago by Andrei Mouravski

Modified:
7 years, 2 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, blois, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for getContextAttributes which wraps bare dictionary into a Dart type. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29221

Patch Set 2 : More test stuff and docs. #

Patch Set 4 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -4 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/html/html_common/conversions.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	sdk/lib/html/html_common/html_common_dart2js.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1	2 chunks	+31 lines, -1 line	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/html/webgl_1_test.dart	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tools/dom/docs/docs.json	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Still doing a little bit of testing, but please take a look.

7 years, 2 months ago (2013-10-23 00:34:19 UTC) #1

sra1

Looking good so far. https://codereview.chromium.org/35863006/diff/30001/tests/html/webgl_1_test.dart File tests/html/webgl_1_test.dart (right): https://codereview.chromium.org/35863006/diff/30001/tests/html/webgl_1_test.dart#newcode98 tests/html/webgl_1_test.dart:98: expect(attributes, new isInstanceOf<gl.ContextAttributes>()); Also check ...

7 years, 2 months ago (2013-10-23 04:15:43 UTC) #2

Andrei Mouravski

Here you go. https://codereview.chromium.org/35863006/diff/30001/tests/html/webgl_1_test.dart File tests/html/webgl_1_test.dart (right): https://codereview.chromium.org/35863006/diff/30001/tests/html/webgl_1_test.dart#newcode98 tests/html/webgl_1_test.dart:98: expect(attributes, new isInstanceOf<gl.ContextAttributes>()); On 2013/10/23 04:15:44, ...

7 years, 2 months ago (2013-10-24 18:09:49 UTC) #3

Andrei Mouravski

7 years, 2 months ago (2013-10-24 22:32:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r29221 (presubmit successful).

Expand Messages | Collapse Messages