Issue 358413003: Run new MessageEvent constructor instead of initMessageEvent in Firefox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 358413003: Run new MessageEvent constructor instead of initMessageEvent in Firefox. (Closed)

Created:
6 years, 5 months ago by Emily Fortuna

Modified:
6 years, 5 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Run new MessageEvent constructor instead of initMessageEvent in Firefox. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=37843

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/html/messageevent_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_MessageEvent.darttemplate	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for https://code.google.com/p/dart/issues/detail?id=15651

6 years, 5 months ago (2014-06-30 17:55:48 UTC) #1

blois

https://codereview.chromium.org/358413003/diff/20001/tools/dom/templates/html/impl/impl_MessageEvent.darttemplate File tools/dom/templates/html/impl/impl_MessageEvent.darttemplate (right): https://codereview.chromium.org/358413003/diff/20001/tools/dom/templates/html/impl/impl_MessageEvent.darttemplate#newcode18 tools/dom/templates/html/impl/impl_MessageEvent.darttemplate:18: if (Device.isFirefox) { If their change was done to ...

6 years, 5 months ago (2014-06-30 20:54:32 UTC) #2

Emily Fortuna

6 years, 5 months ago (2014-06-30 23:03:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37843 (presubmit successful).

Expand Messages | Collapse Messages

Issue 358413003: Run new MessageEvent constructor instead of initMessageEvent in Firefox. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages