Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 357763004: Observatory requests coverage per script (Closed)

Created:
6 years, 6 months ago by Michael Lippautz (Google)
Modified:
6 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, Cutch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : add deployed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -308 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 7 chunks +10 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 91 chunks +135 lines, -133 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 7 chunks +10 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 91 chunks +135 lines, -133 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/polymer/polymer.html View 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/layout.html View 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.js View 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/web_components/platform.js View 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 3 6 chunks +36 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
6 years, 6 months ago (2014-06-25 22:46:32 UTC) #1
Cutch
(It's best to not include the deployed directory changes until we've hit LGTM.) Can you ...
6 years, 6 months ago (2014-06-26 15:37:21 UTC) #2
Michael Lippautz (Google)
PTAL
6 years, 6 months ago (2014-06-26 20:07:04 UTC) #3
Cutch
lgtm
6 years, 5 months ago (2014-06-27 18:00:13 UTC) #4
Michael Lippautz (Google)
6 years, 5 months ago (2014-06-27 18:12:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r37794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698