Issue 357623002: Mark try/end_to_end_test as slow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 357623002: Mark try/end_to_end_test as slow. (Closed)

Created:
6 years, 6 months ago by karlklose

Modified:
6 years, 6 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark try/end_to_end_test as slow. The test times out on the chrome-linux bots but seems to run OK on chrome-windows, so let's try to give a bit more time. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=37683

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/try/try.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

Committed patchset #1 manually as r37683 (presubmit successful).

6 years, 6 months ago (2014-06-25 07:51:28 UTC) #3

ahe

I'd really appreciate being CC'ed on CLs involving Try Dart. The test only times out ...

6 years, 6 months ago (2014-06-25 16:51:01 UTC) #4

karlklose

6 years, 6 months ago (2014-06-26 06:11:53 UTC) #5

Message was sent while issue was closed.

On 2014/06/25 16:51:01, ahe wrote:
> I'd really appreciate being CC'ed on CLs involving Try Dart.
> 
> The test only times out when something is really broken, so you may as well
skip
> it, there is no need to wait for it to time out.

Sorry, will do in the future. I am not sure what is going on with this test, as
it has started passing again in build #2637. I'll mark it as skip.

Expand Messages | Collapse Messages