Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 35743002: Make docgen able to generate pkg docs and save the package names (Closed)

Created:
7 years, 2 months ago by Alan Knight
Modified:
7 years, 1 month ago
Reviewers:
terry
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Make docgen able to generate pkg docs and save the package names R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=29387

Patch Set 1 #

Patch Set 2 : Make sure we have an ending newline in index.txt, also write a JSON index, and include packageName … #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -92 lines) Patch
M pkg/docgen/bin/dartdoc.py View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/docgen/bin/docgen.dart View 2 chunks +29 lines, -28 lines 0 comments Download
A pkg/docgen/bin/generate_all_docs.sh View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/docgen/bin/upload_docgen.py View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 28 chunks +116 lines, -59 lines 1 comment Download
M pkg/docgen/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
This adds a property packageName to the generated Library object and find the package name ...
7 years, 2 months ago (2013-10-22 18:42:49 UTC) #1
terry
LGTM just one minor suggestion. https://chromiumcodereview.appspot.com/35743002/diff/40001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://chromiumcodereview.appspot.com/35743002/diff/40001/pkg/docgen/lib/docgen.dart#newcode335 pkg/docgen/lib/docgen.dart:335: filteredEntities.map((e) => e.typeName)); Minor ...
7 years, 2 months ago (2013-10-24 14:17:30 UTC) #2
Alan Knight
7 years, 1 month ago (2013-10-28 20:12:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698