Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 357283003: Fix listeners being added to subscription after onListen was called. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Fix listeners being added to subscription after onListen was called. BUG= http://dartbug.com/19722 R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -43 lines) Patch
M sdk/lib/async/broadcast_stream_controller.dart View 2 chunks +13 lines, -4 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 4 chunks +21 lines, -7 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 4 chunks +26 lines, -18 lines 0 comments Download
M sdk/lib/async/stream_pipe.dart View 2 chunks +12 lines, -9 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/lib/async/stream_controller_test.dart View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-06-30 12:07:18 UTC) #1
floitsch
LGTM.
6 years, 5 months ago (2014-06-30 12:24:57 UTC) #2
Søren Gjesse
lgtm
6 years, 5 months ago (2014-06-30 12:56:55 UTC) #3
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-01 07:14:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698