Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 357003002: Fix list_path_observer, temporarily add a test for it, but we'll likely remove (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix list_path_observer, temporarily add a test for it, but we'll likely remove it in the future since it's no longer in observe-js. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -7 lines) Patch
M pkg/observe/lib/src/list_path_observer.dart View 3 chunks +4 lines, -7 lines 0 comments Download
A pkg/observe/test/list_path_observer_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-27 01:04:04 UTC) #1
Jennifer Messerly
lgtm. thanks siggi!
6 years, 6 months ago (2014-06-27 01:10:34 UTC) #2
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-27 01:25:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698