Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 35693010: Fix VM issue 1372: super constructor invocation with redirection. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix VM issue 1372: super constructor invocation with redirection. A redirecting super constructor simply passes the phase parameter on to the target which executes the corresponding phase. BUG=https://code.google.com/p/dart/issues/detail?id=1372 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=29097

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M runtime/vm/parser.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-10-23 14:43:32 UTC) #1
hausner
LGTM. https://codereview.chromium.org/35693010/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/35693010/diff/1/runtime/vm/parser.cc#newcode2510 runtime/vm/parser.cc:2510: current_block_->statements->Add(init_statements); Would be nice to add the description ...
7 years, 2 months ago (2013-10-23 15:50:31 UTC) #2
Florian Schneider
https://codereview.chromium.org/35693010/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/35693010/diff/1/runtime/vm/parser.cc#newcode2510 runtime/vm/parser.cc:2510: current_block_->statements->Add(init_statements); On 2013/10/23 15:50:31, hausner wrote: > Would be ...
7 years, 2 months ago (2013-10-23 16:03:48 UTC) #3
Florian Schneider
7 years, 2 months ago (2013-10-23 16:18:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698