Issue 356623002: Reduce size of PCDescriptors. Order struct fields so that they do not get padded unnecessarily.

Issue 356623002: Reduce size of PCDescriptors. Order struct fields so that they do not get padded unnecessarily. (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 5 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reduce size of PCDescriptors. Order struct fields so that they do not get padded unnecessarily. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=37674

Patch Set 3 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -94 lines)			Patch
M	runtime/vm/object.h	View	1 2	3 chunks	+33 lines, -41 lines	2 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/356623002/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/356623002/diff/20001/runtime/vm/object.h#newcode3022 runtime/vm/object.h:3022: rec->deopt_id = deopt_id; Assert that deopt_id and token_pos ...

6 years, 6 months ago (2014-06-24 23:25:50 UTC) #2

srdjan

https://codereview.chromium.org/356623002/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/356623002/diff/20001/runtime/vm/object.h#newcode3022 runtime/vm/object.h:3022: rec->deopt_id = deopt_id; On 2014/06/24 23:25:49, zra wrote: > ...

6 years, 6 months ago (2014-06-24 23:31:02 UTC) #3

srdjan

Committed patchset #3 manually as r37674 (presubmit successful).

6 years, 6 months ago (2014-06-24 23:50:59 UTC) #4

siva

6 years, 6 months ago (2014-06-25 21:44:33 UTC) #5

Message was sent while issue was closed.

DBC..

https://codereview.chromium.org/356623002/diff/40001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/356623002/diff/40001/runtime/vm/object.h#newc...
runtime/vm/object.h:3017: int64_t token_pos,  // Or deopt reason.
Why is the signature changed to int64_t instead of int32_t ?

https://codereview.chromium.org/356623002/diff/40001/runtime/vm/object.h#newc...
runtime/vm/object.h:3018: intptr_t try_index) const {  // Or deopt index.
Why not change this to int16_t

Expand Messages | Collapse Messages