Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 356573002: Revert "Move Compiler.libraries to LibraryLoder." (Closed)

Created:
6 years, 6 months ago by floitsch
Modified:
6 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Move Compiler.libraries to LibraryLoder." This reverts commit r37659. Committed: https://code.google.com/p/dart/source/detail?r=37663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -116 lines) Patch
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 6 chunks +12 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dump_info.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 5 chunks +21 lines, -43 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors_used.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart View 1 chunk +1 line, -5 lines 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation2_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/deferred_mirrors_test.dart View 4 chunks +9 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/deferred_not_in_main_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/in_user_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/tag_mapping_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR. Unfortunately broke the try end-to-end test. python tools/test.py -mrelease -cdart2js -rff --use-sdk --write-debug-log --write-test-outcome-log ...
6 years, 6 months ago (2014-06-24 17:29:47 UTC) #1
floitsch
Committed patchset #1 manually as r37663 (presubmit successful).
6 years, 6 months ago (2014-06-24 17:32:23 UTC) #2
Johnni Winther
6 years, 6 months ago (2014-06-25 06:51:24 UTC) #3
Message was sent while issue was closed. 
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698