Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 356523003: Add implicit constraints from pub onto stack_trace and source_maps. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add implicit constraints from pub onto stack_trace and source_maps. These packages are used in pub's plugin isolate, so pub needs to have a dependency on them to ensure their APIs don't change out from under it. R=rnystrom@google.com BUG=19574 Committed: https://code.google.com/p/dart/source/detail?r=37751

Patch Set 1 #

Total comments: 11

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -89 lines) Patch
M pkg/barback/pubspec.yaml View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/stack_trace/pubspec.yaml View 1 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback.dart View 2 chunks +23 lines, -13 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 5 chunks +71 lines, -57 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart View 8 chunks +39 lines, -16 lines 0 comments Download
A sdk/lib/_internal/pub/test/implicit_dependency_test.dart View 1 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 6 months ago (2014-06-25 23:06:26 UTC) #1
Bob Nystrom
Couple of nits, but LGTM. This came out really nice. https://codereview.chromium.org/356523003/diff/1/pkg/source_maps/pubspec.yaml File pkg/source_maps/pubspec.yaml (right): https://codereview.chromium.org/356523003/diff/1/pkg/source_maps/pubspec.yaml#newcode3 ...
6 years, 6 months ago (2014-06-26 16:37:34 UTC) #2
nweiz
https://codereview.chromium.org/356523003/diff/1/pkg/source_maps/pubspec.yaml File pkg/source_maps/pubspec.yaml (right): https://codereview.chromium.org/356523003/diff/1/pkg/source_maps/pubspec.yaml#newcode3 pkg/source_maps/pubspec.yaml:3: # Note! This version is referenced directly in the ...
6 years, 6 months ago (2014-06-26 20:03:49 UTC) #3
nweiz
6 years, 6 months ago (2014-06-26 20:04:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698