Issue 356433002: coverage: Improve generation, see below.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356433002: coverage: Improve generation, see below. (Closed)

Created:
6 years, 6 months ago by Michael Lippautz (Google)

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

coverage: Improve generation, see below. * Ignore non-valid PC descriptors, i.e., descriptors where tokens are not within range of the actual function. * Merge line data where it would be consecutively emitted. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37662

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -9 lines)			Patch
M	runtime/vm/coverage.cc	View	5 chunks	+31 lines, -9 lines	0 comments	Download
A	runtime/vm/coverage_test.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Lippautz (Google)

6 years, 6 months ago (2014-06-24 16:41:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37662 (presubmit successful).

Expand Messages | Collapse Messages