Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 355823008: Avoid instantiating even a stub stacktrace when neither the catch clause nor the (Closed)

Created:
6 years, 6 months ago by rmacnak
Modified:
6 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid instantiating even a stub stacktrace when neither the catch clause nor the exception require it. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37717

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M runtime/vm/exceptions.cc View 1 1 chunk +38 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
Test in https://chromiumcodereview.appspot.com/342473006
6 years, 6 months ago (2014-06-25 17:25:00 UTC) #1
siva
lgtm
6 years, 6 months ago (2014-06-25 21:12:35 UTC) #2
rmacnak
6 years, 6 months ago (2014-06-26 01:13:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698