Issue 355453005: Add a Resource.parent getter, which gets the parent directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355453005: Add a Resource.parent getter, which gets the parent directory. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a Resource.parent getter, which gets the parent directory. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37746

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -20 lines)			Patch
M	pkg/analysis_server/lib/src/resource.dart	View	4 chunks	+40 lines, -20 lines	2 comments	Download
M	pkg/analysis_server/test/physical_resource_provider_test.dart	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/resource_test.dart	View	2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/355453005/diff/1/pkg/analysis_server/lib/src/resource.dart File pkg/analysis_server/lib/src/resource.dart (right): https://codereview.chromium.org/355453005/diff/1/pkg/analysis_server/lib/src/resource.dart#newcode74 pkg/analysis_server/lib/src/resource.dart:74: * Return the [Folder] that contains this resource, ...

6 years, 6 months ago (2014-06-25 21:44:25 UTC) #2

Paul Berry

https://codereview.chromium.org/355453005/diff/1/pkg/analysis_server/lib/src/resource.dart File pkg/analysis_server/lib/src/resource.dart (right): https://codereview.chromium.org/355453005/diff/1/pkg/analysis_server/lib/src/resource.dart#newcode74 pkg/analysis_server/lib/src/resource.dart:74: * Return the [Folder] that contains this resource, or ...

6 years, 6 months ago (2014-06-26 15:03:08 UTC) #3

Paul Berry

6 years, 6 months ago (2014-06-26 15:03:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37746 (presubmit successful).

Expand Messages | Collapse Messages