Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 355453002: Reland: Fix tools/full-coverage.dart script and add standalone test. (Closed)

Created:
6 years, 6 months ago by Michael Lippautz (Google)
Modified:
6 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Reland: Fix tools/full-coverage.dart script and add standalone test. Test checks coverage data of a given script and differentiates between: * no coverage data * no hits (IC=0) * some hits (IC>0) BUG= R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=37627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -3 lines) Patch
A tests/standalone/full_coverage_test.dart View 1 chunk +231 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/full-coverage.dart View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Lippautz (Google)
Original CL: https://codereview.chromium.org/348473004/ The test did depend on a valid sdk path although it doesn't ...
6 years, 6 months ago (2014-06-23 16:37:57 UTC) #1
rmacnak
lgtm
6 years, 6 months ago (2014-06-23 21:44:26 UTC) #2
Michael Lippautz (Google)
6 years, 6 months ago (2014-06-23 22:27:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698