Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 35543007: Make type variables belong to the original declaration in VM. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
zarah, gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe
Visibility:
Public.

Description

Make type variables belong to the original declaration in VM. BUG=http://dartbug.com/14240 R=gbracha@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=29106

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 3 chunks +5 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/mirrors/type_variable_owner_test.dart View 4 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-23 00:48:29 UTC) #1
gbracha
test lgtm
7 years, 2 months ago (2013-10-23 00:53:37 UTC) #2
zarah
LGTM!
7 years, 2 months ago (2013-10-23 06:23:58 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-23 18:28:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698