Fix type errors detected with --error-on-bad-type.

Fix type errors detected with --error-on-bad-type.

R=nweiz@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29047

[Siggi Cherem (dart-lang), 2013-10-22 22:59:21]

I had no idea about this flag, it's really nice.

Nathan, most changes are in barback. Regis, I'm adding you to make sure the fix
in collections_patch.dart looks right.

Thanks!

[regis, 2013-10-22 23:03:41]

LGTM

Did you try --error_on_bad_override? It reports an error as well.

[nweiz, 2013-10-22 23:18:23]

One comment, otherwise lgtm.

https://codereview.chromium.org/35543006/diff/1/pkg/barback/lib/src/transform...
File pkg/barback/lib/src/transform.dart (right):

https://codereview.chromium.org/35543006/diff/1/pkg/barback/lib/src/transform...
pkg/barback/lib/src/transform.dart:9: import 'package:source_maps/span.dart'
show Span;
Style nit: add a newline before this. Also, we tend not to use "show" unless
it's specifically necessary in a file. Same goes fro transform_node.dart.

[Siggi Cherem (dart-lang), 2013-10-22 23:41:13]

Committed patchset #1 manually as r29047 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-10-22 23:41:18]

https://codereview.chromium.org/35543006/diff/1/pkg/barback/lib/src/transform...
File pkg/barback/lib/src/transform.dart (right):

https://codereview.chromium.org/35543006/diff/1/pkg/barback/lib/src/transform...
pkg/barback/lib/src/transform.dart:9: import 'package:source_maps/span.dart'
show Span;
On 2013/10/22 23:18:23, nweiz wrote:
> Style nit: add a newline before this. Also, we tend not to use "show" unless
> it's specifically necessary in a file. Same goes fro transform_node.dart.

Done.