Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 355203009: Rewrite 'throw thrownException' with 'throw new AnalysisException(...)' (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rewrite 'throw thrownException' with 'throw new AnalysisException(...)' R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineExceptionProcessor.java View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 18 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-01 22:01:58 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-01 22:15:33 UTC) #2
scheglov
6 years, 5 months ago (2014-07-01 22:16:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698