Issue 355013002: Change new Uri(query:"") to not add a query part.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355013002: Change new Uri(query:"") to not add a query part. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change new Uri(query:"") to not add a query part. This is for backwards compatibility. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=37731

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	sdk/lib/core/uri.dart	View		2 chunks	+5 lines, -0 lines	2 comments	Download
	M	tests/co19/co19-co19.status	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/355013002/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/355013002/diff/1/sdk/lib/core/uri.dart#newcode514 sdk/lib/core/uri.dart:514: // Special case this constructor for backwards compatibility. ...

6 years, 6 months ago (2014-06-26 11:04:32 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/355013002/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/355013002/diff/1/sdk/lib/core/uri.dart#newcode514 sdk/lib/core/uri.dart:514: // Special case this constructor for backwards compatibility. I'll ...

6 years, 6 months ago (2014-06-26 11:14:05 UTC) #3

Lasse Reichstein Nielsen

6 years, 6 months ago (2014-06-26 11:14:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37731 (presubmit successful).

Expand Messages | Collapse Messages