Issue 354653003: Fix busted type parameters in yaml.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354653003: Fix busted type parameters in yaml.

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix busted type parameters in yaml. R=rnystrom@google.com

Patch Set 2 : fix analyzer warning #

Patch Set 3 : changelog entry #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	pkg/yaml/CHANGELOG.md	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_node_wrapper.dart	View	1	2 chunks	+4 lines, -2 lines	2 comments	Download
M	pkg/yaml/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit, but LGTM! https://codereview.chromium.org/354653003/diff/40001/pkg/yaml/lib/src/yaml_node_wrapper.dart File pkg/yaml/lib/src/yaml_node_wrapper.dart (right): https://codereview.chromium.org/354653003/diff/40001/pkg/yaml/lib/src/yaml_node_wrapper.dart#newcode65 pkg/yaml/lib/src/yaml_node_wrapper.dart:65: // inference. "local type inference" ...

6 years, 6 months ago (2014-06-24 20:03:49 UTC) #4

nweiz

6 years, 6 months ago (2014-06-24 20:04:45 UTC) #5

https://codereview.chromium.org/354653003/diff/40001/pkg/yaml/lib/src/yaml_no...
File pkg/yaml/lib/src/yaml_node_wrapper.dart (right):

https://codereview.chromium.org/354653003/diff/40001/pkg/yaml/lib/src/yaml_no...
pkg/yaml/lib/src/yaml_node_wrapper.dart:65: // inference.
On 2014/06/24 20:03:49, Bob Nystrom wrote:
> "local type inference" -> "type propagation"

Done.

Expand Messages | Collapse Messages

Issue 354653003: Fix busted type parameters in yaml.

Description

Patch Set 1 #

Patch Set 2 : fix analyzer warning #

Patch Set 3 : changelog entry #

Messages