Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 353993002: Multivm branch: Fetch reference build from archive using git hash, not revision. (Closed)

Created:
6 years, 6 months ago by Bill Hesse
Modified:
6 years, 5 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Multivm branch: Fetch reference build from archive using git hash, not revision. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=37732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M dart/tools/bots/get_chromium_build.py View 3 chunks +5 lines, -7 lines 0 comments Download
M deps/multivm.deps/DEPS View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
6 years, 6 months ago (2014-06-26 11:29:30 UTC) #1
ricow1
lgtm
6 years, 6 months ago (2014-06-26 11:31:58 UTC) #2
Bill Hesse
6 years, 6 months ago (2014-06-26 11:32:33 UTC) #3
Bill Hesse
Committed patchset #1 manually as r37732 (presubmit successful).
6 years, 6 months ago (2014-06-26 11:33:08 UTC) #4
ricow1
6 years, 5 months ago (2014-06-26 15:10:55 UTC) #5
Message was sent while issue was closed.
We may want to chose another reference build for windows, we seem to be crashing
on windows

Powered by Google App Engine
This is Rietveld 408576698