Retain script path of parent isolate when spawnFunction is called so that

Fix for issue 14236:
Retain script path of parent isolate when spawnFunction is called so that
it works when using script snapshots.

The test case issue14236_test.dart is a script snapshot whose original source
file path is issue14236_source.dart

R=iposva@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29178

[Ivan Posva, 2013-10-23 20:59:19]

LGTM, but we should commit the original source for the snapshot too. With the
only change to fail when it is ever called.

-Ivan

[siva, 2013-10-24 00:26:22]

Added the orginal source code into the repository with an expected failure if it
is run.

[Søren Gjesse, 2013-10-24 07:21:40]

lgtm

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:464: ASSERT(isolate_data);
isolate_data != NULL

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:465: ASSERT(isolate_data->script_url);
isolate_data->script_url != NULL

https://codereview.chromium.org/35393003/diff/190001/tests/standalone/standal...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/35393003/diff/190001/tests/standalone/standal...
tests/standalone/standalone.status:58: issue14236_test: Skip # Script snapshots
do not work in the browser.
Please add the issue number in the comment as well.

[siva, 2013-10-24 16:25:03]

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:464: ASSERT(isolate_data);
On 2013/10/24 07:21:41, Søren Gjesse wrote:
> isolate_data != NULL

Done.

https://codereview.chromium.org/35393003/diff/190001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:465: ASSERT(isolate_data->script_url);
On 2013/10/24 07:21:41, Søren Gjesse wrote:
> isolate_data->script_url != NULL

Done.

https://codereview.chromium.org/35393003/diff/190001/tests/standalone/standal...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/35393003/diff/190001/tests/standalone/standal...
tests/standalone/standalone.status:58: issue14236_test: Skip # Script snapshots
do not work in the browser.
On 2013/10/24 07:21:41, Søren Gjesse wrote:
> Please add the issue number in the comment as well.

Done.

[siva, 2013-10-24 16:41:32]

Committed patchset #4 manually as r29178 (presubmit successful).

[Florian Schneider, 2013-10-25 13:34:02]

On 2013/10/24 16:41:32, siva wrote:
> Committed patchset #4 manually as r29178 (presubmit successful).

I don't think it is a good idea to have a binary snapshot in the repository. Why
not make this a cc-test, create and run the snapshot via the Dart API?