Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 353453004: Remove dead code for tracking pubspec.yaml files. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove dead code for tracking pubspec.yaml files. Now that we are using "pub list-package-dirs" to find the packages associated with a context, we no longer need to explicitly track the presence or absence of a "pubspec.yaml" file within the context. Note that we will have to watch the "pubspec.lock" file in order to decide when to re-run "pub list-package-dirs", but we'll do this using a different mechanism, since the decision of which file(s) to watch is the responsibility of pub, and communicated to us through the JSON output of "pub list-package-dirs". This will be addressed in a future CL. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=37620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -67 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_directory_manager.dart View 5 chunks +3 lines, -37 lines 0 comments Download
M pkg/analysis_server/test/context_directory_manager_test.dart View 9 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 6 months ago (2014-06-23 18:13:34 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-23 19:45:15 UTC) #2
Paul Berry
6 years, 6 months ago (2014-06-23 21:34:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698