Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 353003005: Display average time between collections (Closed)

Created:
6 years, 6 months ago by Cutch
Modified:
6 years, 6 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Display average time between collections BUG= R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=37749

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -26 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 3 chunks +15 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 3 chunks +15 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_profile.html View 1 2 chunks +14 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_profile.html View 2 chunks +14 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
6 years, 6 months ago (2014-06-26 17:42:57 UTC) #1
koda
Did you consider using 'uptime' from the VM object to do the division on the ...
6 years, 6 months ago (2014-06-26 17:49:39 UTC) #2
Cutch
On 2014/06/26 17:49:39, koda wrote: > Did you consider using 'uptime' from the VM object ...
6 years, 6 months ago (2014-06-26 17:56:03 UTC) #3
koda
LGTM https://codereview.chromium.org/353003005/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/353003005/diff/1/runtime/vm/pages.cc#newcode389 runtime/vm/pages.cc:389: int64_t run_time = OS::GetCurrentTimeMicros() - isolate->start_time(); Note to ...
6 years, 6 months ago (2014-06-26 19:42:38 UTC) #4
Cutch
6 years, 6 months ago (2014-06-26 19:53:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37749 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698