Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 352923002: Gracefully handle transformers rejecting their configuration. (Closed)

Created:
6 years, 6 months ago by nweiz
Modified:
6 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Gracefully handle transformers rejecting their configuration. R=rnystrom@google.com BUG=16008 Committed: https://code.google.com/p/dart/source/detail?r=37752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart View 2 chunks +15 lines, -0 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/a_transformer_rejects_its_config_test.dart View 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 6 months ago (2014-06-26 00:17:58 UTC) #1
Bob Nystrom
lgtm
6 years, 6 months ago (2014-06-26 16:44:37 UTC) #2
nweiz
6 years, 6 months ago (2014-06-26 20:05:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698