send status notification when analysis starts and ends

send status notification when analysis starts and ends

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37734

[Paul Berry, 2014-06-25 19:38:16]

lgtm

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:108: bool statusAnalyzing =
false;
How about if we call this "wasAnalyzing"

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:374: // Only send status when
it changes
Then this code can look like:

  bool isAnalyzing = (operation != null);
  if (isAnalyzing == wasAnalyzing) {
    return;
  }
  wasAnalyzing = isAnalyzing;
  ...
  analysis['analyzing'] = isAnalyzing;

Not a huge deal, I just think the function would read a little more easily this
way.  Your call.

[danrubel, 2014-06-26 11:53:22]

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:108: bool statusAnalyzing =
false;
On 2014/06/25 19:38:16, Paul Berry wrote:
> How about if we call this "wasAnalyzing"

I want to convey that this field is associated with sending status messages to
the client. It is not immediately apparent that 'wasAnalyzing' is associated
with sending status.

https://codereview.chromium.org/352823005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:374: // Only send status when
it changes
On 2014/06/25 19:38:16, Paul Berry wrote:
> Then this code can look like:
> 
>   bool isAnalyzing = (operation != null);
>   if (isAnalyzing == wasAnalyzing) {
>     return;
>   }
>   wasAnalyzing = isAnalyzing;
>   ...
>   analysis['analyzing'] = isAnalyzing;
> 
> Not a huge deal, I just think the function would read a little more easily
this
> way.  Your call.

You're right. I like it better that way. Done.

[danrubel, 2014-06-26 11:53:49]

Committed patchset #2 manually as r37734 (presubmit successful).