Issue 352523002: Fix parsing and resolving of prefixed names

Issue 352523002: Fix parsing and resolving of prefixed names (Closed)

Created:
6 years, 6 months ago by hausner

Modified:
6 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix parsing and resolving of prefixed names R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=37631

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -107 lines)			Patch
M	runtime/vm/parser.h	View	1 2	3 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	11 chunks	+140 lines, -99 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3	3 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/language/malformed_test.dart	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/352523002/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/352523002/diff/20001/runtime/vm/parser.cc#newcode3148 runtime/vm/parser.cc:3148: // rather than via the class? Isn't it ...

6 years, 6 months ago (2014-06-23 17:32:36 UTC) #2

hausner

Committed patchset #4 manually as r37631 (presubmit successful).

6 years, 6 months ago (2014-06-23 23:26:32 UTC) #3

hausner

6 years, 6 months ago (2014-06-23 23:27:15 UTC) #4

Message was sent while issue was closed.

Thank you. Issues addressed and a couple more fixes added.

https://codereview.chromium.org/352523002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/352523002/diff/20001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:3148: // rather than via the class?
On 2014/06/23 17:32:36, regis wrote:
> Isn't it a good time to remove this TODO?

It is. As it turns out, the library_ field cached in the parser contains the
right library in all cases, so we can look up the prefix directly there.

https://codereview.chromium.org/352523002/diff/20001/tests/language/language_...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/352523002/diff/20001/tests/language/language_...
tests/language/language_dart2js.status:9: malformed_test/05:
MissingCompileTimeError # Issue 12695
On 2014/06/23 17:32:36, regis wrote:
> This test may be wrong.

The test is wrong, and we passed it for the wrong reason. The compiler tripped
over parsing the type. Parsing a type with malformed prefix is a bit more
subtle. Changed ParseNewOperator and where we parse forwarding constructors.

This in turn unmasked a buggy co19 test.

Expand Messages | Collapse Messages