Try to retain original structure of URI.

Try to retain original structure of URI.

This changes URI.parse to retain empty autorities, queries and fragments.
That is: `Uri.parse("foo:///x?#")` will give a Uri with toString "foo:///x?#",
as opposed to the previous "foo:/".

It also makes a difference between passing "" and null to the Uri constructor.

We still omit empty user-info and default port values from the toString.

R=ajohnsen@google.com

BUG= http://dartbug.com/2216

Committed: https://code.google.com/p/dart/source/detail?r=37690

Committed: https://code.google.com/p/dart/source/detail?r=37728

[Anders Johnsen, 2014-06-25 09:18:01]

lgtm, I like it. Less magic :)

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcode57
sdk/lib/core/uri.dart:57: * The value is always non-null.
This contradicts with the getter below.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcode91
sdk/lib/core/uri.dart:91: * Also returns 0 if there is no port number in the
authority component.
remove 'Also', it only returns once.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:448: * the URI will not have a scheme part.
will have an empty scheme part?

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:503: port,
int port

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:1421: if (_port == null) return "$scheme://$_host";
Maybe use the new getters?

[Lasse Reichstein Nielsen, 2014-06-25 10:49:18]

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcode57
sdk/lib/core/uri.dart:57: * The value is always non-null.
True, I don't need the getter anyway.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcode91
sdk/lib/core/uri.dart:91: * Also returns 0 if there is no port number in the
authority component.
On 2014/06/25 09:18:00, Anders Johnsen wrote:
> remove 'Also', it only returns once.

Done.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:448: * the URI will not have a scheme part.
That sounds like an empty string before a colon, which it isn't.
There is no colon, so no scheme part.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:503: port,
On 2014/06/25 09:18:00, Anders Johnsen wrote:
> int port

Done.

https://codereview.chromium.org/352093003/diff/1/sdk/lib/core/uri.dart#newcod...
sdk/lib/core/uri.dart:1421: if (_port == null) return "$scheme://$_host";
hasPort? 

I *try* not to use public overridable members in other members.
Sometimes they are just too convenient, though.

[Lasse Reichstein Nielsen, 2014-06-25 11:16:48]

Committed patchset #5 manually as r37690 (presubmit successful).

[Lasse Reichstein Nielsen, 2014-06-25 11:57:42]

Reverted - breaks dart2js in interesting ways.

[Lasse Reichstein Nielsen, 2014-06-25 13:33:21]

dart2js breakage fixed. PTAL.

[Anders Johnsen, 2014-06-26 08:19:02]

lgtm

[Lasse Reichstein Nielsen, 2014-06-26 09:41:39]

Committed patchset #6 manually as r37728 (presubmit successful).