Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 352063006: observatory: add note on how to use pub to generate deployed/ directory (Closed)

Created:
6 years, 6 months ago by Michael Lippautz (Google)
Modified:
6 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/bin/vmservice/client/HACKING.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
Maybe? Maybe not? ... deployed/ right now only holds only JS related files. Quite confusing ...
6 years, 6 months ago (2014-06-25 22:56:04 UTC) #1
Cutch
On 2014/06/25 22:56:04, Michael Lippautz wrote: > Maybe? Maybe not? ... > > deployed/ right ...
6 years, 6 months ago (2014-06-26 14:57:56 UTC) #2
Michael Lippautz (Google)
PTAL On 2014/06/26 14:57:56, Cutch wrote: > On 2014/06/25 22:56:04, Michael Lippautz wrote: > > ...
6 years, 6 months ago (2014-06-26 16:43:39 UTC) #3
Cutch
lgtm
6 years, 6 months ago (2014-06-26 18:37:28 UTC) #4
Michael Lippautz (Google)
6 years, 6 months ago (2014-06-26 20:07:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698