Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 351453004: Move split_store.dart to the store/ folder and extract collections/codecs. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move split_store.dart to the store/ folder and extract collections/codecs. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -3155 lines) Patch
D pkg/analysis_server/lib/src/index/split_store.dart View 1 chunk +0 lines, -1167 lines 0 comments Download
A pkg/analysis_server/lib/src/index/store/codec.dart View 1 chunk +216 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/index/store/collection.dart View 1 chunk +116 lines, -0 lines 0 comments Download
A + pkg/analysis_server/lib/src/index/store/split_store.dart View 15 chunks +18 lines, -297 lines 0 comments Download
D pkg/analysis_server/test/index/split_store_test.dart View 1 chunk +0 lines, -1366 lines 0 comments Download
A pkg/analysis_server/test/index/store/codec_test.dart View 1 chunk +178 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/index/store/collection_test.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A + pkg/analysis_server/test/index/store/split_store_test.dart View 17 chunks +42 lines, -315 lines 0 comments Download
A + pkg/analysis_server/test/index/store/test_all.dart View 1 chunk +11 lines, -8 lines 0 comments Download
A pkg/analysis_server/test/index/store/typed_mocks.dart View 1 chunk +83 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/index/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-06-21 22:17:51 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-23 13:47:33 UTC) #2
scheglov
6 years, 6 months ago (2014-06-23 17:18:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698