Defer marking libraries as ‘loaded’

Defer marking libraries as ‘loaded’

Now that loading of libraries and library parts are loaded asynchronously and calls to Dart_LoadLibrary are serialized instead of nested, we must wait until the last load request is satisfied before marking libraries as ‘loaded’.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37824

[Ivan Posva, 2014-06-26 08:37:46]

LGTM

-Ivan

https://codereview.chromium.org/350923005/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/350923005/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:5149: isolate->DoneLoading();
We should consider moving all of the code below into DoneLoading() or is there
any reason to call Isolate::DoneLoading() without triggering class finalization
and the completion of deferred loads?

Different CL.

[hausner, 2014-06-30 17:11:14]

Committed patchset #2 manually as r37824 (presubmit successful).

[hausner, 2014-06-30 17:18:43]

https://codereview.chromium.org/350923005/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/350923005/diff/1/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:5149: isolate->DoneLoading();
On 2014/06/26 08:37:46, Ivan Posva wrote:
> We should consider moving all of the code below into DoneLoading() or is there
> any reason to call Isolate::DoneLoading() without triggering class
finalization
> and the completion of deferred loads?
> 
> Different CL.

Added a TODO.