Issue 350763003: [polymer] rename d-auto-binding to auto-binding-dart

Issue 350763003: [polymer] rename d-auto-binding to auto-binding-dart (Closed)

Created:
6 years, 6 months ago by Jennifer Messerly

Modified:
6 years, 6 months ago

Reviewers:
justinfagnani, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

rename d-auto-binding to auto-binding-dart appending -dart to ports seems like a more generic convention R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37633

Patch Set 2 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	pkg/polymer/lib/auto_binding.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/polymer/lib/src/loader.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/auto_binding_test.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/web_components/pubspec.yaml	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Committed patchset #2 manually as r37633 (presubmit successful).

6 years, 6 months ago (2014-06-24 00:47:23 UTC) #3

justinfagnani

lgtm https://codereview.chromium.org/350763003/diff/20001/pkg/web_components/pubspec.yaml File pkg/web_components/pubspec.yaml (right): https://codereview.chromium.org/350763003/diff/20001/pkg/web_components/pubspec.yaml#newcode2 pkg/web_components/pubspec.yaml:2: version: 0.3.5-dev.4 why?

6 years, 6 months ago (2014-06-24 00:47:37 UTC) #4

Jennifer Messerly

6 years, 6 months ago (2014-06-24 00:49:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/350763003/diff/20001/pkg/web_components/pubsp...
File pkg/web_components/pubspec.yaml (right):

https://codereview.chromium.org/350763003/diff/20001/pkg/web_components/pubsp...
pkg/web_components/pubspec.yaml:2: version: 0.3.5-dev.4
On 2014/06/24 00:47:37, justinfagnani wrote:
> why?

ah, follow up from last CL. Since I'm going to release Polymer now (otherwise
was going to wait for Siggi's 0.11 change), and I don't know if the newest
Polymer also depends on newest platform.js (probably not, but sometimes does),
going to release both to be on the safe side.

Expand Messages | Collapse Messages