Issue 350443006: Add secret option "live" which compiles more frequently.

Issue 350443006: Add secret option "live" which compiles more frequently. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, kasperl, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add secret option "live" which compiles more frequently. This option is mostly useful for recording screencasts of incremental compilation. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37643

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
M	dart/site/try/src/interaction_manager.dart	View		3 chunks	+9 lines, -1 line	0 comments	Download
M	dart/site/try/src/settings.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	dart/site/try/src/user_option.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart File dart/site/try/src/settings.dart (right): https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart#newcode97 dart/site/try/src/settings.dart:97: How do you enable a hidden option?

6 years, 6 months ago (2014-06-24 06:31:35 UTC) #2

ahe

Thank you, Johnni. https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart File dart/site/try/src/settings.dart (right): https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart#newcode97 dart/site/try/src/settings.dart:97: On 2014/06/24 06:31:34, Johnni Winther wrote: ...

6 years, 6 months ago (2014-06-24 06:41:48 UTC) #3

ahe

https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart File dart/site/try/src/settings.dart (right): https://codereview.chromium.org/350443006/diff/1/dart/site/try/src/settings.dart#newcode97 dart/site/try/src/settings.dart:97: On 2014/06/24 06:41:47, ahe wrote: > On 2014/06/24 06:31:34, ...

6 years, 6 months ago (2014-06-24 06:55:41 UTC) #4

ahe

Johnni, I'm going to submit this as soon as I have re-run tests. But I'd ...

6 years, 6 months ago (2014-06-24 08:36:02 UTC) #5

ahe

Committed patchset #2 manually as r37643 (presubmit successful).

6 years, 6 months ago (2014-06-24 08:40:06 UTC) #6

Johnni Winther

6 years, 6 months ago (2014-06-24 08:49:31 UTC) #7

Message was sent while issue was closed.

On 2014/06/24 08:40:06, ahe wrote:
> Committed patchset #2 manually as r37643 (presubmit successful).

No spjelling errors ;-)

Expand Messages | Collapse Messages